fix(ui): make a more deterministic build #15820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexpaxton
reviewed
Nov 8, 2019
| @@ -29,7 +29,6 @@ | |||
| } | |||
|
|
|||
| .getting-started--card { | |||
| position: absolute; | |||
There was a problem hiding this comment.
Does removing this not break anything visually?
There was a problem hiding this comment.
i have no idea as these classes aren't scoped, was leaning on you for that 😬
There was a problem hiding this comment.
this line WAS getting overwritten on your branch in dev mode, but when production flipped the css rule order, this is what made the giant page thing
desa
approved these changes
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15842
Closes influxdata/clockface#362
we saw some weirdness where css inclusion order was changed when building in production mode. this was the result of some drift between our dev and production environments (specifically the use of MiniCssExtract). I went ahead and dragged as much into the common webpack as made sense to hopefully make our build process feel a bit more deterministic.
the second commit is me fixing the error that used to only show up in production, but now should show up everywhere (cause same same, but different)