Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): Delay threshold re-rendering until mouse up when dragging markers #15975

Merged
merged 1 commit into from
Nov 19, 2019
Merged

fix(ui): Delay threshold re-rendering until mouse up when dragging markers #15975

merged 1 commit into from
Nov 19, 2019

Conversation

TCL735
Copy link
Contributor

@TCL735 TCL735 commented Nov 19, 2019

Closes #15832

Single marker dragging fix:

single_marker_dragging

Double marker dragging fix:

double_marker_dragging

alexpaxton
alexpaxton approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@alexpaxton alexpaxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. The delay feels really natural and makes sense from a performance standpoint

@TCL735 TCL735 merged commit bb6c666 into master Nov 19, 2019
@TCL735 TCL735 deleted the fix_15832_dragging_markers branch November 19, 2019 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexpaxton alexpaxton alexpaxton approved these changes

@mavarius mavarius Awaiting requested review from mavarius

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

threshold value dragging is weird
2 participants
@TCL735 @alexpaxton