Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(http): add cell properties to dashboard response #16057

Merged
merged 5 commits into from
Dec 3, 2019

Conversation

dearyhud
Copy link
Contributor

@dearyhud dearyhud commented Nov 27, 2019

Closes #16052

Describe your proposed changes here.
Adds an optional ?include=properties query string to GET /dashboards/:dashboardID that returns each cells properties

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

Copy link
Contributor

@imogenkinsman imogenkinsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add the new param to our swagger :)

@dearyhud dearyhud force-pushed the 15898/dashboard-api-tweaks branch from f6e6a7b to e09f09b Compare November 29, 2019 16:23
@dearyhud dearyhud requested review from a team as code owners November 29, 2019 16:23
http/dashboard_service.go Outdated Show resolved Hide resolved
Copy link
Contributor

@ebb-tide ebb-tide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome !! Thanks for doing this!

@dearyhud dearyhud force-pushed the 15898/dashboard-api-tweaks branch from 6ae4dbb to 1a9fe28 Compare December 2, 2019 19:03
@dearyhud dearyhud changed the title feat: adds properties to each cell on GET /dashboards/:dashboardID feat(http): cell properties to GET /dashboards/:dashboardID Dec 2, 2019
@dearyhud dearyhud force-pushed the 15898/dashboard-api-tweaks branch from 1779159 to 6aaefe9 Compare December 2, 2019 22:47
@dearyhud dearyhud changed the title feat(http): cell properties to GET /dashboards/:dashboardID feat(http): add cell properties to dashboard response Dec 2, 2019
@dearyhud dearyhud force-pushed the 15898/dashboard-api-tweaks branch from 6aaefe9 to e237b3d Compare December 2, 2019 22:57
@dearyhud dearyhud force-pushed the 15898/dashboard-api-tweaks branch from e237b3d to b36a926 Compare December 3, 2019 16:56
Copy link
Contributor

@jsteenb2 jsteenb2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets give it a try

@dearyhud dearyhud force-pushed the 15898/dashboard-api-tweaks branch from b36a926 to 9eff6b9 Compare December 3, 2019 18:47
@dearyhud dearyhud merged commit e21ebeb into master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

return nested data in dashboard get request
4 participants