Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): updated webpack to account for different wasm files #16194

Merged
merged 3 commits into from
Dec 11, 2019

Conversation

asalem1
Copy link
Contributor

@asalem1 asalem1 commented Dec 11, 2019

Closes #16098

Problem

wasm files were being compiled based on new rules that were not being applied to the query parser

Solution

Updated the webpack rules to bifurcate the rules to account for the query parser and the rest of the wasm files

  • CHANGELOG.md updated with a link to the PR (not the Issue)

@asalem1 asalem1 requested review from drdelambre and desa December 11, 2019 00:59
Copy link
Contributor

@drdelambre drdelambre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks for making sure it works!

@asalem1 asalem1 merged commit b62f294 into master Dec 11, 2019
@drdelambre drdelambre deleted the windowPeriod branch December 11, 2019 16:58
alexpaxton pushed a commit that referenced this pull request Jan 9, 2020
fix(ui): updated webpack to account for different wasm files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v.windowPeriod is not dynamically updated
2 participants