Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return the telegraf module based on Loadable's interface #16207

Merged
merged 1 commit into from
Dec 11, 2019
Merged

fix: return the telegraf module based on Loadable's interface #16207

merged 1 commit into from
Dec 11, 2019

Conversation

hoorayimhelping
Copy link
Contributor

@hoorayimhelping hoorayimhelping commented Dec 11, 2019 •
edited
Loading

Closes #16205

Changes what is exported from Loadable so that it properly conforms and returns an element.

@hoorayimhelping hoorayimhelping force-pushed the bs_fix_edit_telegraf_config branch from 2548d52 to 6398381 Compare December 11, 2019 20:11
drdelambre
drdelambre approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@drdelambre drdelambre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hoorayimhelping hoorayimhelping force-pushed the bs_fix_edit_telegraf_config branch from 6398381 to 175f715 Compare December 11, 2019 20:34
@hoorayimhelping hoorayimhelping merged commit efdc6e5 into master Dec 11, 2019
@hoorayimhelping hoorayimhelping deleted the bs_fix_edit_telegraf_config branch December 11, 2019 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drdelambre drdelambre drdelambre approved these changes

@ebb-tide ebb-tide Awaiting requested review from ebb-tide

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI - Telegraf] - Editing a Telegraf config causes a crash
2 participants
@hoorayimhelping @drdelambre