fix(ui): Prevent negative zero and allow zero with decimal places #16439
Conversation
ghost
requested review from
asalem1 and
hoorayimhelping
and removed request for
a team
| import {DecimalPlaces} from 'src/types/dashboards' | ||
|
|
||
| // Constants | ||
| import {MAX_DECIMAL_PLACES} from 'src/dashboards/constants' |
| export const preventNegativeZero = ( | ||
| value: number | string | ||
| ): number | string => { | ||
| if (Number(value) === -0) { |
There was a problem hiding this comment.
Literally didn't know this was possible
There was a problem hiding this comment.
take control back from the machines!
no but seriously, go ahead and use overrides here to get more value out of our tests. in general, use an override like this for lint or prettier or whatever, whenever they get mouthy and you think what you're writing is valuable.
| maximumFractionDigits: MAX_DECIMAL_PLACES, | ||
| }) | ||
| localeFormattedValue = | ||
| Number(roundedValue) === 0 |
There was a problem hiding this comment.
what do you think of turning this code into a formatting function and including the negative zero check as part of it?
There was a problem hiding this comment.
This piece of code is actually inside a formatting function already. The ternary is to allow positive zero to have decimal places when user-specified.
| import {preventNegativeZero} from 'src/shared/utils/preventNegativeZero' | ||
|
|
||
| describe('preventNegativeZero', () => { | ||
| it('should not alter non-zero numbers', () => { |
There was a problem hiding this comment.
nice test! was going to ask why you can't just use Math.abs but this one answers it nicely.
…6439) * fix(ui): Prevent negative zero and allow zero with decimal places * chore: update CHANGELOG * fix(ui): Turn off lint rule no-compare-neg-zero * test: add more tests by overriding prettier * fix(ui): turn off lint rule for a specific usage, not universally
Closes #16306