-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): fixed dashboard cells and check query builder update bug #17202
Conversation
fbc67dd
to
b5ea518
Compare
@@ -2638,7 +2638,7 @@ func (q queries) influxDashQueries() []influxdb.DashboardQuery { | |||
EditMode: "advanced", | |||
} | |||
// TODO: axe this builder configs when issue https://github.com/influxdata/influxdb/issues/15708 is fixed up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anyone else curious about this foreboding line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, definitely shows it to @gavincabbage this morning, especially since the issue was closed a couple days ago. I'd love to see @desa 's opinion on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
js lgtm
b5ea518
to
1970b74
Compare
Closes #17130
Problem
Solution
Updated the
BuilderConfig tag
struct to account for theAggregateFunctionType
that had been passed in by the UI but was not being stored on the API. The consequence of this action allows the UI to have access to theaggregateFunctionType
as a reference for making changes in the query builder. Put simply, the existing query builder is built around the fact that anaggregateFunctionType
will be passed in as a tag property, but it was not.Check Update Fix:
Dashboard Cell Fix: