-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pkger): add stack init cmd to influx cli #17448
Conversation
fc3fa20
to
ee12282
Compare
return err | ||
} | ||
|
||
const fakeUserID = 0 // is 0 because user is pulled from token... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The userID can be inferred from the token if you use the auth service, but I'm not sure I understand what it's being used for here.
Is it a problem for the userID to be 0 in some cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the ID is real or not, the user assoicated with the token is what is used when creating resources at this time. That is pretty consistent across the API at this pint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments / questions.
More broadly, I'm not sure I understand why a CLI command is necessary for a stack. I assumed it was going to be an internal implementation detail, not something that users interacted with directly.
@jademcgough that's a good question. Say you are boostrapping your app for the first time. You've created your org, user, bucket, and now you want a stack to associate with some packages you want in the platform. That stack can be bootstrapped with this call here. The stack can have associated urls, which apply will automatically pull and run for the user associated with the stack_id provided. This avoids the user having to juggle side effects during run time. Does that help illuminate the need for this? |
ee12282
to
31a0f32
Compare
31a0f32
to
fb5e2a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just make sure, double test it out before merge
closes: #17235