feat(dashboards): improve view spinners #18447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r and views Co-Authored-By: Zoe Steinkamp <zoesteinkamp@users.noreply.github.com>
Co-Authored-By: Zoe Steinkamp <zoesteinkamp@users.noreply.github.com>
Co-Authored-By: Zoe Steinkamp <zoesteinkamp@users.noreply.github.com>
alexpaxton
requested review from
a team and
TCL735
and removed request for
a team
TCL735
approved these changes
Jun 10, 2020
|
🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18323
Upon investigating the issue we found that there is in fact a loading indicator but it had a few problems. One being that it was extremely subtle and the other being it only displayed on some view types and not on others.
Our solution:
Redesign the loading state to be way more obvious
If the view is loading for more than
5sa timer appears to additionally display load timeRefreshingGraphinstead of individually in each view componentLoadingand if it stays inLoadingstate longer than 5s reveal the duration