chore(build): add grace test runs to daily PR checks #20210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxmoran
reviewed
Nov 30, 2020
| background: true | ||
| - run: docker run --net host -v /var/run/docker.sock:/var/run/docker.sock -v ~/project:/grace/test-results/grace-results quay.io/influxdb/grace:daily | ||
| - store_artifacts: | ||
| path: ~/project |
There was a problem hiding this comment.
Should we add this block:
- store_test_results:
path: ~/projectTo match grace_nightly?
There was a problem hiding this comment.
Actually we should remove the store_test_results: from grace_nightly.The results are being uploaded by store_artifact step
| - run: | ||
| command: ./bin/linux/influxd --store=memory --log-level=debug | ||
| background: true | ||
| - run: docker run --net host -v /var/run/docker.sock:/var/run/docker.sock -v ~/project:/grace/test-results/grace-results quay.io/influxdb/grace:daily |
There was a problem hiding this comment.
Is --net host the flag that enables the Docker image to see the influxd instance running in the background?
There was a problem hiding this comment.
The short answer is yes
danxmoran
approved these changes
Nov 30, 2020
gshif
added a commit
that referenced
this pull request
Dec 1, 2020
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Describe your proposed changes here.