Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add upgrade helper script to nfpms manifest #20339

Merged
merged 2 commits into from
Dec 15, 2020
Merged

fix: add upgrade helper script to nfpms manifest #20339

merged 2 commits into from
Dec 15, 2020

Conversation

danxmoran
Copy link
Contributor

Closes #20337

Tested using these steps:

  1. Ran our CI docker image
  2. Cloned this branch
  3. Ran make nightly to generate archives
  4. Ran dpkg -i on the generated .deb
  5. Copy-pasted the command to run the upgrade script, and confirmed it ran without modifications

@psteinbachs psteinbachs self-requested a review December 15, 2020 17:04
psteinbachs
psteinbachs approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@psteinbachs psteinbachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@danxmoran danxmoran merged commit 37ffc4b into master Dec 15, 2020
@danxmoran danxmoran deleted the dm-archive-include-helper-20337 branch December 15, 2020 21:09
danxmoran added a commit that referenced this pull request Dec 15, 2020
@danxmoran
fix: add upgrade helper script to nfpms manifest (#20339)
922ea32
@danxmoran danxmoran mentioned this pull request Dec 15, 2020
Merged
danxmoran added a commit that referenced this pull request Dec 17, 2020
@danxmoran
fix: add upgrade helper script to nfpms manifest (#20339)
4b76c63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psteinbachs psteinbachs psteinbachs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release archives are missing upgrade helper script
2 participants
@danxmoran @psteinbachs