fix(kit/cli): don't ignore failures to mark CLI options as required #20490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxmoran
force-pushed
the
dm-no-ignore-err-cli-required-20394
branch
from
a49711a to
17eb99d
Compare
lesam
reviewed
Jan 12, 2021
danxmoran
force-pushed
the
dm-no-ignore-err-cli-required-20394
branch
from
17eb99d to
561d054
Compare
danxmoran
force-pushed
the
dm-no-ignore-err-cli-required-20394
branch
from
561d054 to
0e53755
Compare
This was referenced Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20394
We can only mark a flag as required after it's been registered in the
cobra.Command.