feat(internal/cmd): add internal command for influxdb flux test harness #20508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
force-pushed
the
feat/test-harness
branch
from
f1472bc to
b1b8a87
Compare
rockstar
approved these changes
Jan 21, 2021
| } | ||
|
|
||
| func (t *testExecutor) Errorf(s string, i ...interface{}) { | ||
| t.Logf(s, i...) |
There was a problem hiding this comment.
This interface, that looks a lot like testing.T interface, is quite neat. I like it a lot, and will likely take out my hack in idpe and put this in its place. Thanks for the idea.
The internal command can be used to execute flux tests using the same internals as the `flux test` command, but it will invoke these tests against a test influxdb instance that is launched in-process.
jsternberg
force-pushed
the
feat/test-harness
branch
from
b1b8a87 to
e95922c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal command can be used to execute flux tests using the same
internals as the
flux testcommand, but it will invoke these testsagainst a test influxdb instance that is launched in-process.
Closes #19882.