fix(tsm): should not check write-ahead-log size against default size #20585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the submission @foobar! Could you please:
|
foobar
force-pushed
the
2.0-check-wal-seg-size
branch
from
d14466c to
9cfeef7
Compare
done
added test case |
foobar
force-pushed
the
2.0-check-wal-seg-size
branch
2 times, most recently
from
797ef38 to
c198f38
Compare
danxmoran
reviewed
Feb 9, 2021
| "cpu,host=C#!~#value": []tsm1.Value{tsm1.NewValue(1, 1.0)}, | ||
| } | ||
| if _, err := w.WriteMulti(values); err != nil { | ||
| fatal(t, "write points", err) |
There was a problem hiding this comment.
it's just following the convention of other functions in this file. fatal() wraps Fatalf
|
|
||
| encodeSize := int64(0) | ||
| if files, err := ioutil.ReadDir(w.Path()); err != nil { | ||
| fatal(t, "ReadDir", err) |
|
|
||
| for i := 0; i < 100; i++ { | ||
| if _, err := w.WriteMulti(values); err != nil { | ||
| fatal(t, "write points", err) |
| } | ||
| files, err := ioutil.ReadDir(w.Path()) | ||
| if err != nil { | ||
| fatal(t, "ReadDir", err) |
| fatal(t, "ReadDir", err) | ||
| } | ||
| for _, f := range files { | ||
| if f.Size() > int64(segSize)+encodeSize { |
There was a problem hiding this comment.
Suggested change
| if f.Size() > int64(segSize)+encodeSize { | |
| if f.Size() > int64(segSize) + encodeSize { |
There was a problem hiding this comment.
gofmt doesn't add space here
tsdb/engine/tsm1/wal_test.go
Outdated
| } else if len(files) != 1 { | ||
| t.Fatalf("unexpected segments size %d", len(files)) | ||
| } else { | ||
| encodeSize = files[0].Size() |
There was a problem hiding this comment.
Style nit: I don't think this needs to be wrapped in the else, since the other cases cause the test to bail out
There was a problem hiding this comment.
And if you move it out of the else, you could remove encodeSize := int64(0) above and define it a single time.
it should check against the local saved SegmentSize instead of the default const DefaultSegmentSize.
foobar
force-pushed
the
2.0-check-wal-seg-size
branch
from
66f94ac to
8a5a13e
Compare
danxmoran
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it should check against the local saved SegmentSize instead of the
default const DefaultSegmentSize.