Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct the default port desc to 8086 #20809

Merged
merged 4 commits into from
Mar 2, 2021

Conversation

sunjincheng121
Copy link
Contributor

Correct the default port desc to 8086. as the default port has been changed.[1]

[1] #19494

  • [-] Tests pass

@danxmoran danxmoran self-assigned this Feb 26, 2021
@danxmoran danxmoran self-requested a review February 26, 2021 15:21
Copy link
Contributor

@danxmoran danxmoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunjincheng121 thanks for the contribution! Since this affects the UI, I think it's worthy of a changelog entry. Could you add the following line to CHANGELOG.md, at the bottom of the Bug Fixes section under unreleased?

1. [20809](https://github.com/influxdata/influxdb/pull/20809): Fix InfluxDB port in Flux function UI examples. Thanks @sunjincheng121!

@sunjincheng121
Copy link
Contributor Author

Thanks for the reminder @danxmoran , I have update the PR accordingly.

Copy link
Contributor

@danxmoran danxmoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sunjincheng121! I'll take it from here, the CI can be annoying to keep up with as others merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants