Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add legendHide for the tooltip #21547

Merged
merged 3 commits into from
May 25, 2021
Merged

feat: add legendHide for the tooltip #21547

merged 3 commits into from
May 25, 2021

Conversation

TCL735
Copy link
Contributor

@TCL735 TCL735 commented May 25, 2021

Closes influxdata/ui#1456

Adds a property to hide the tooltip independently of the static legend

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Feature flagged (if modified API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@TCL735 TCL735 requested a review from a team as a code owner May 25, 2021 02:25
@TCL735 TCL735 requested a review from glinton May 25, 2021 02:45
glinton
glinton approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@glinton glinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work as always, timmy

@TCL735 TCL735 force-pushed the feat_ui_1456_tooltip_hide branch from df101a6 to 5978e1e Compare May 25, 2021 17:00
@TCL735
Copy link
Contributor Author

TCL735 commented May 25, 2021

Force push was to resolve merge conflicts.

@TCL735 TCL735 merged commit b0d62f0 into master May 25, 2021
@TCL735 TCL735 deleted the feat_ui_1456_tooltip_hide branch May 25, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glinton glinton glinton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Legend: hide the tooltip
2 participants
@TCL735 @glinton