Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: delete duplicate jobs for grace/litmus, update nightly workflow #22220

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

danxmoran
Copy link
Contributor

Ever since #22186, litmus tests have been passing against merges to master but failing in our nightly builds. I investigated and found that the way litmus is invoked in the nightly build caused it to pull & test the quay.io/influxdb/influxdb2:nightly image. This image is:

  1. Undocumented
  2. Not auto-updated by any process

Rather than pour more energy into litmus, I've updated the nightly workflow to use the same litmus-test process as the workflow that runs per-commit.

I made a similar change for our grace tests because I've noticed they can be flaky in nightly runs, I think because of timing issues when the grace suite tries to launch influxd in Docker vs. us launching influxd as a pre-step before the tests.

@danxmoran danxmoran requested a review from codyshepherd August 17, 2021 14:53
@codyshepherd
Copy link
Contributor

Looks like you're getting build failures from #22221. Rebasing on the latest master should fix.

@danxmoran danxmoran force-pushed the dm-consolidate-litmus-and-grace branch 2 times, most recently from 8f7a8e8 to 8f44969 Compare August 17, 2021 18:25
@danxmoran danxmoran force-pushed the dm-consolidate-litmus-and-grace branch from 8f44969 to 7e57a87 Compare August 17, 2021 18:34
@danxmoran danxmoran merged commit bfc54e1 into master Aug 17, 2021
@danxmoran danxmoran deleted the dm-consolidate-litmus-and-grace branch August 17, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants