Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: switch flux formatter to one that preserves comments #22242

Merged
merged 2 commits into from
Aug 17, 2021
Merged

fix: switch flux formatter to one that preserves comments #22242

merged 2 commits into from
Aug 17, 2021

Conversation

danxmoran
Copy link
Contributor

Closes #22213

Backports #22186

@danxmoran danxmoran requested a review from a team as a code owner August 17, 2021 19:49
@danxmoran danxmoran removed the request for review from a team August 17, 2021 19:50
@williamhbaker williamhbaker self-requested a review August 17, 2021 19:59
williamhbaker
williamhbaker approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@williamhbaker williamhbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danxmoran danxmoran merged commit 2844820 into 2.0 Aug 17, 2021
@danxmoran danxmoran deleted the dm-backport-flux-formatter-upgrade-22213 branch August 17, 2021 20:52
@danxmoran danxmoran mentioned this pull request Aug 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamhbaker williamhbaker williamhbaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danxmoran @williamhbaker