feat(tsi): optimize series iteration #22316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using queries like 'select count(_seriesKey) from bigmeasurement`, we should iterate over the tsi structures to serve the query instead of loading all the series into memory up front.
|
This looks like a fine forward port, but are we sure we want it for 2.x ? The main use in 1.x is for |
|
I don't know of any existing cardinality-related optimizations in 2.x. Flux isn't able to query it directly until #21513 is done, and AFAIK the influxql engine is a close port of the behavior from pre-1.9. There could be something in the code that I'm not aware of, though. I also think we want to merge this in so we can forward-port the InfluxQL HLL functions that depend on it (@dgnorton confirmed we want those functions in 2.x InfluxQL). |
lesam
approved these changes
Aug 26, 2021
This was referenced Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22314
Forward-ports #20544