feat: add virtual DBRP mappings based on bucket name #23606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required checklist
Description
Originally, I worked on #23525 to create and update physical DBRP mappings in the bucket service wrapper. This solution meant more state needed to be preserved, required a migration, etc. Virtual mappings, on the other hand, are not written on disk (corruptible), would be changed by a bucket name change implicitly, and overall made much more sense with less code.
Context
This makes it so users don't have to create a custom DBRP mapping every time they create a bucket.
Affected areas:
DBRPMappinggained aVirtualfield - feat: add virtual field to DBRP schema openapi#462influx v1 dbrp listprints a newVirtualcolumn - feat: add virtual column to DBRP printing influx-cli#435