chore: update core deps #25532
Merged
chore: update core deps #25532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveen-influx
force-pushed
the
chore/update-core-deps
branch
2 times, most recently
from
f807b55 to
d67e837
Compare
- arrow/parquet deps are patched (as in core)
- three specific code changes to cope with changes in core crates
- TransitionPartitionId, use `from_parts` instead of `new`
- arrow buffers can take &[u8] directly without `to_vec()`/`vec!`
(used only in tests)
- `schema` and `influxdb_line_protocol` crates need `v3` feature enabled
Unicode-3.0 license is added to allowed licenses list, without it end up with 19 errors (`zerovec`, `zerovec-derive` etc.)
praveen-influx
force-pushed
the
chore/update-core-deps
branch
from
d67e837 to
9ccfc1b
Compare
praveen-influx
requested review from
hiltontj,
pauldix,
mgattozzi and
jdstrand
and removed request for
pauldix
praveen-influx
commented
Nov 12, 2024
| @@ -405,24 +405,6 @@ impl Database { | |||
|
|
|||
| #[async_trait] | |||
| impl QueryNamespace for Database { | |||
| async fn chunks( | |||
There was a problem hiding this comment.
This method has been removed from QueryNamespace trait
hiltontj
reviewed
Nov 12, 2024
influxdb3_catalog/Cargo.toml
Outdated
| @@ -9,7 +9,7 @@ license.workspace = true | |||
| # Core Crates | |||
| influxdb-line-protocol.workspace = true | |||
| observability_deps.workspace = true | |||
| schema.workspace = true | |||
| schema = { workspace = true, features = ["v3"] } | |||
There was a problem hiding this comment.
Might be good to keep the feature set at the workspace level, then don't need to set it in each individual cargo file.
There was a problem hiding this comment.
To clarify, it was previously set in the workspace Cargo.toml. Having it there could save someone a few head scratches if they pull one of the v3 featured crates and find things broken, and I'm not sure we would ever have a crate that depends on one of these and does not use the feature.
jdstrand
reviewed
Nov 12, 2024
- move enabling v3 feature to root Cargo.toml - added the upstream PR for datafusion-common that introduced RUSTSEC-2024-0384
jdstrand
approved these changes
Nov 12, 2024
mgattozzi
pushed a commit
that referenced
this pull request
Feb 10, 2025
* chore: update core deps
- arrow/parquet deps are patched (as in core)
- three specific code changes to cope with changes in core crates
- TransitionPartitionId, use `from_parts` instead of `new`
- arrow buffers can take &[u8] directly without `to_vec()`/`vec!`
(used only in tests)
- `schema` and `influxdb_line_protocol` crates need `v3` feature enabled
* chore: update deny.toml
* chore: formatting and deny toml changes
Unicode-3.0 license is added to allowed licenses list, without it
end up with 19 errors (`zerovec`, `zerovec-derive` etc.)
* chore: address PR feedback
- move enabling v3 feature to root Cargo.toml
- added the upstream PR for datafusion-common that introduced RUSTSEC-2024-0384
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from_partsinstead ofnewto_vec()/vec!(used only in tests)
schemaandinfluxdb_line_protocolcrates needv3feature enabled