fix(inputs.kafka_consumer): Fix deadlock (#16074)

influxdata · Oct 24, 2024 · 662607c · 662607c
1 parent f061114
commit 662607c
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/plugins/inputs/kafka_consumer/kafka_consumer.go b/plugins/inputs/kafka_consumer/kafka_consumer.go
@@ -64,7 +64,6 @@ type KafkaConsumer struct {
 	topicClient     sarama.Client
 	regexps         []regexp.Regexp
 	allWantedTopics []string
-	ticker          *time.Ticker
 	fingerprint     string
 
 	parser    telegraf.Parser
@@ -376,15 +375,13 @@ func (k *KafkaConsumer) Gather(_ telegraf.Accumulator) error {
 }
 
 func (k *KafkaConsumer) Stop() {
-	if k.ticker != nil {
-		k.ticker.Stop()
-	}
 	// Lock so that a topic refresh cannot start while we are stopping.
 	k.topicLock.Lock()
-	defer k.topicLock.Unlock()
 	if k.topicClient != nil {
 		k.topicClient.Close()
 	}
+	k.topicLock.Unlock()
+
 	k.cancel()
 	k.wg.Wait()
 }