Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net_response doesn't respect 'timeout' field. #1214

Closed
chalmerj opened this issue May 17, 2016 · 0 comments · Fixed by #1246
Closed

net_response doesn't respect 'timeout' field. #1214

chalmerj opened this issue May 17, 2016 · 0 comments · Fixed by #1246
Labels
bug unexpected problem or unintended behavior

Comments

@chalmerj
Copy link

The input plugin 'net_response' doesn't respect the 'timeout' configuration field. This is evident when attempting to connect to down hosts.

When testing the net_response plugin against a down host (that is, a host not responding to any traffic, rather than a closed TCP port), the plugin hangs indefinitely, rather than ending the TCP / UDP collection activity after the timeout period elapses.

It does not appear in the code that the timeout field is actually read or used anywhere. It looks like the go src for dialTCP accepts a 'deadline' flag, which seems apropos.

Thanks so much!
@sparrc sparrc added the bug unexpected problem or unintended behavior label May 18, 2016
sparrc added a commit that referenced this issue May 23, 2016
@sparrc
Utilize timeout in net_response plugin.
2455451 
Also changing the net_response and http_response plugins to only accept
duration strings for their timeout parameters. This is a breaking config
file change.

closes #1214
sparrc added a commit that referenced this issue May 23, 2016
@sparrc
Utilize timeout in net_response plugin.
eeec070 
Also changing the net_response and http_response plugins to only accept
duration strings for their timeout parameters. This is a breaking config
file change.

closes #1214
@sparrc sparrc mentioned this issue May 23, 2016
Merged
1 task
sparrc added a commit that referenced this issue May 23, 2016
@sparrc
Utilize timeout in net_response plugin.
cf895ec 
Also changing the net_response and http_response plugins to only accept
duration strings for their timeout parameters. This is a breaking config
file change.

closes #1214
sparrc added a commit that referenced this issue May 23, 2016
@sparrc
Utilize timeout in net_response plugin.
c44ecf5 
Also changing the net_response and http_response plugins to only accept
duration strings for their timeout parameters. This is a breaking config
file change.

closes #1214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Utilize timeout in net_response plugin. influxdata/telegraf
2 participants
@chalmerj @sparrc