Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow wildcards for Varnish stats #1275

Closed
joshuaspence opened this issue May 25, 2016 · 1 comment · Fixed by #1280
Closed

Allow wildcards for Varnish stats #1275

joshuaspence opened this issue May 25, 2016 · 1 comment · Fixed by #1280

Comments

@joshuaspence
Copy link

#1173 added a varnish plugin, which is awesome. The default stats collected are ["MAIN.cache_hit", "MAIN.cache_miss", "MAIN.uptime"]. I want to collect as many stats as possible, so I set this config to ["all"]. This seems to cause some issues though:

> telegraf -input-filter varnish -test
2016/05/25 19:01:47 Using config file: /etc/telegraf/telegraf.conf
* Plugin: varnish, Collection 1
Expected a numeric value for VBE.READACTED(X.X.X.X,,80).happy = 18446744073709551615
Expected a numeric value for VBE.READACTED(X.X.X.X,,80).happy = 18446744073709551615
Expected a numeric value for VBE.READACTED(X.X.X.X,,80).happy = 18446744073709551615
Expected a numeric value for VBE.READACTED(X.X.X.X,,80).happy = 18446744073709551615
Expected a numeric value for VBE.READACTED(X.X.X.X,,80).happy = 18446744073709551615
Expected a numeric value for VBE.READACTED(X.X.X.X,,80).happy = 18446744073709551615
Expected a numeric value for VBE.READACTED(X.X.X.X,,80).happy = 18446744073709551615
Expected a numeric value for VBE.READACTED(X.X.X.X,,80).happy = 18446744073709551615
Expected a numeric value for VBE.READACTED(X.X.X.X,,80).happy = 18446744073709551615
Expected a numeric value for VBE.READACTED(X.X.X.X,,80).happy = 18446744073709551615
Expected a numeric value for VBE.READACTED(X.X.X.X,,80).happy = 18446744073709551615
Expected a numeric value for VBE.READACTED(X.X.X.X,,80).happy = 18446744073709551615
Expected a numeric value for VBE.READACTED(X.X.X.X,,80).happy = 18446744073709551615
Expected a numeric value for VBE.READACTED(X.X.X.X,,80).happy = 18446744073709551615
Expected a numeric value for VBE.READACTED(X.X.X.X,,80).happy = 18446744073709551615
Expected a numeric value for VBE.READACTED(X.X.X.X,,80).happy = 18446744073709551615
Expected a numeric value for VBE.READACTED(X.X.X.X,,80).happy = 18446744073709551615
Expected a numeric value for VBE.READACTED(X.X.X.X,,80).happy = 18446744073709551615
Expected a numeric value for VBE.READACTED(X.X.X.X,,80).happy = 18446744073709551615
Expected a numeric value for VBE.READACTED(X.X.X.X,,80).happy = 18446744073709551615
Expected a numeric value for VBE.READACTED(X.X.X.X,,80).happy = 18446744073709551615
Expected a numeric value for VBE.READACTED(X.X.X.X,,80).happy = 18446744073709551615
Expected a numeric value for VBE.READACTED(X.X.X.X,,80).happy = 18446744073709551615
Expected a numeric value for VBE.READACTED(X.X.X.X,,80).happy = 18446744073709551615
Expected a numeric value for VBE.READACTED(X.X.X.X,,80).happy = 18446744073709551615
Expected a numeric value for VBE.READACTED(X.X.X.X,,80).happy = 18446744073709551615
Expected a numeric value for VBE.READACTED(X.X.X.X,,80).happy = 18446744073709551615
Expected a numeric value for VBE.READACTED(X.X.X.X,,80).happy = 18446744073709551615
Expected a numeric value for VBE.READACTED(X.X.X.X,,80).happy = 18446744073709551615
Expected a numeric value for VBE.READACTED(X.X.X.X,,80).happy = 18446744073709551615
Expected a numeric value for VBE.READACTED(X.X.X.X,,80).happy = 18446744073709551615
Expected a numeric value for VBE.READACTED(X.X.X.X,,80).happy = 18446744073709551615
Expected a numeric value for VBE.READACTED(X.X.X.X,,80).happy = 18446744073709551615
...

Instead, I was going to try collecting ["MAIN.*"], but the plugin doesn't seem to support wildcards.

@ljagiello
Copy link
Contributor

ljagiello commented May 26, 2016

Wildcards would be really great (I think I fix that), the problem you show in output (Expected a numeric value…) is connected metrics type - it's int and should be uint64 (fixed here: #1276)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants