Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#5024: Add option to store cpu as a tag in interrupts input) breaks compatibility #5836

Closed
bofh16 opened this issue May 11, 2019 · 1 comment · Fixed by #5850
Closed

(#5024: Add option to store cpu as a tag in interrupts input) breaks compatibility #5836

bofh16 opened this issue May 11, 2019 · 1 comment · Fixed by #5850
Labels
regression something that used to work, but is now broken
Milestone

Comments

@bofh16
Copy link

bofh16 commented May 11, 2019

Relevant telegraf.conf:

[[inputs.interrupts]]
        cpu_as_tag = false

System info:

Linux 3.10.0-957.12.1.el7.x86_64 #1 SMP Mon Apr 29 14:59:59 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
CentOS Linux release 7.6.1810 (Core)

telegraf --version
Telegraf 1.10.3 (git: HEAD 294bb666)

Steps to reproduce:

> show field keys;
name: soft_interrupts
fieldKey fieldType
-------- ---------
CPU0 integer
CPU1 integer
CPU2 integer
CPU3 integer
count integer
cpu0 integer
cpu1 integer
cpu2 integer
cpu3 integer
total integer

Expected behavior:

Fieldkeys format is expected to be preserved between versions, as well as any other filed, previously used. Not doing so, leaves the data, collected so far, "behind".

Actual behavior:

Data collection is imported in the lower letters keys cpu[0-9] and count. The behavior has changed since v1.10.

Additional info:

@glinton glinton added the regression something that used to work, but is now broken label May 13, 2019
@glinton glinton added this to the 1.10.4 milestone May 13, 2019
@bofh16
Copy link
Author

bofh16 commented May 14, 2019

This might be related.
A new database has been created for a new telegraf client, which has been configured explicitly with the new setting from the beginning.

[[inputs.interrupts]]
cpu_as_tag = true

The result:

> select * from soft_interrupts limit 10;
name: soft_interrupts
time count cpu host irq
---- ----- --- ---- ---
1557827410000000000 15486601 cpu0 webstore BLOCK

> show field keys;
Only this!
name: soft_interrupts
fieldKey fieldType
-------- ---------
count integer

After changing to false and back to true:

> select * from soft_interrupts limit 10;
name: soft_interrupts
time count cpu cpu0 cpu1 cpu2 cpu3 cpu4 cpu5 cpu6 cpu7 host irq total
---- ----- --- ---- ---- ---- ---- ---- ---- ---- ---- ---- --- -----
1557827410000000000 15486601 cpu0 webstore BLOCK

> show field keys;
name: soft_interrupts
fieldKey fieldType
-------- ---------
count integer
cpu0 integer
cpu1 integer
cpu2 integer
cpu3 integer
cpu4 integer
cpu5 integer
cpu6 integer
cpu7 integer
total integer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression something that used to work, but is now broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants