Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert field name case in interrupts input #5850

Merged
merged 2 commits into from
May 14, 2019
Merged

Revert field name case in interrupts input #5850

merged 2 commits into from
May 14, 2019

Conversation

glinton
Copy link
Contributor

@glinton glinton commented May 13, 2019

Resolves #5836

Should we also change the case of the newly added cpu as tag to uppercase to match?

@glinton glinton added the fix pr to fix corresponding bug label May 13, 2019
@glinton glinton added this to the 1.10.4 milestone May 13, 2019
@danielnelson
Copy link
Contributor

Don't forget to update the tests. Let's stay with lowercase cpu in the newer (cpu_as_tag=true) format, since it matches the cpu plugin.

@danielnelson danielnelson merged commit 2d44a88 into master May 14, 2019
@danielnelson danielnelson deleted the bugfix/5836 branch May 14, 2019 18:56
danielnelson pushed a commit that referenced this pull request May 14, 2019
hwaastad pushed a commit to hwaastad/telegraf that referenced this pull request Jun 13, 2019
bitcharmer pushed a commit to bitcharmer/telegraf that referenced this pull request Oct 18, 2019
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(#5024: Add option to store cpu as a tag in interrupts input) breaks compatibility
2 participants