Try to reconnect to Riemann if metrics upload failed. #1013
Conversation
| @@ -68,8 +68,13 @@ func (r *Riemann) Write(metrics []telegraf.Metric) error { | |||
|
|
|||
| var senderr = r.client.SendMulti(events) | |||
| if senderr != nil { | |||
| return errors.New(fmt.Sprintf("FAILED to send riemann message: %s\n", | |||
| senderr)) | |||
| r.Close() | |||
There was a problem hiding this comment.
you shouldn't ignore errors from the Close and Connect functions
echupriyanov
force-pushed
the
riemann_improved
branch
2 times, most recently
from
e3b3cbb
to
95b104f
Compare
|
@sparrc Added better (I hope) error checks. |
Signed-off-by: Eugene Chupriyanov <tchu@tchu.ru> Error checks added Don't Close() nil client Signed-off-by: Eugene Chupriyanov <e.chupriyanov@cpm.ru>
echupriyanov
force-pushed
the
riemann_improved
branch
from
95b104f
to
288b8e0
Compare
| @@ -68,8 +79,16 @@ func (r *Riemann) Write(metrics []telegraf.Metric) error { | |||
|
|
|||
| var senderr = r.client.SendMulti(events) | |||
| if senderr != nil { | |||
There was a problem hiding this comment.
in here I would say just do:
r.Close()
return fmt.Errorf("FAILED to send riemann message (will try to reconnect). Error: %s\n",
senderr)because r.Close will set the connection to nil, and then a connection will be attempted on the next write.
There was a problem hiding this comment.
Yes. But will Telegraf try to re-attempt to send metrics again? Or they would be dropped if send fails?
Anyway, I removed immediate reconnection attempt on send failure.
There was a problem hiding this comment.
the metrics will be cached, telegraf will re-attempt to send
There was a problem hiding this comment.
great, thanks for clarification.
should I squash PR into one commit, if it will be accepted for merge?
There was a problem hiding this comment.
2 commits is fine, I'll merge it
Signed-off-by: Eugene Chupriyanov <e.chupriyanov@cpm.ru>
echupriyanov
force-pushed
the
riemann_improved
branch
from
c237e6a
to
ff672f0
Compare
Signed-off-by: Eugene Chupriyanov tchu@tchu.ru