-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.kafka_consumer): Option to set default fetch message bytes #11220
Merged
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
120a9ca
feat(inputs/kafka_consumer): allow to set default fetch message bytes
AlbertasB cd76f92
feat(inputs/kafka_consumer): allow to set default fetch message bytes
AlbertasB fc2420c
Update README.md
AlbertasB c78a72d
Update kafka_consumer.go
AlbertasB 98172f1
Update kafka_consumer.go
AlbertasB ad4852f
Update kafka_consumer.go
AlbertasB de59cda
Update README.md
AlbertasB 360f17d
remove unecesary file
AlbertasB File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,6 +43,7 @@ type KafkaConsumer struct { | |
BalanceStrategy string `toml:"balance_strategy"` | ||
Topics []string `toml:"topics"` | ||
TopicTag string `toml:"topic_tag"` | ||
FetchMessageBytes int32 `toml:"fetch_message_bytes"` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How about making this a |
||
|
||
kafka.ReadConfig | ||
|
||
|
@@ -127,6 +128,10 @@ func (k *KafkaConsumer) Init() error { | |
|
||
cfg.Consumer.MaxProcessingTime = time.Duration(k.MaxProcessingTime) | ||
|
||
if k.FetchMessageBytes != 0 { | ||
cfg.Consumer.Fetch.Default = k.FetchMessageBytes | ||
} | ||
|
||
k.config = cfg | ||
return nil | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please rename to
consumer_fetch_default
as this is what you ultimately use it as such.