fix(inputs.opcua): Assign node id correctly #11723
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve: #11719
The ID was being set to the local copy of "node" in the loop, in order for the to be saved so it can be used later in the code: https://github.com/influxdata/telegraf/blob/master/plugins/inputs/opcua/opcua.go#L516 it needs to be assigned using the index so that the original value gets updated. More context of this behavior: https://stackoverflow.com/questions/61605727/why-does-normal-for-loop-allows-assigning-value-to-struct-fields-while-for-range