Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inputs.prometheus): Pass namespace to k8s informer factory #13063

Merged
merged 1 commit into from
Apr 12, 2023
Merged

fix(inputs.prometheus): Pass namespace to k8s informer factory #13063

merged 1 commit into from
Apr 12, 2023

Conversation

Ivaylogi98
Copy link
Contributor

@Ivaylogi98 Ivaylogi98 commented Apr 10, 2023 •
edited

Required for all PRs

resolves #12780

Fixed creation of Informer Factory to include given namespace, if present in the config under monitor_kubernetes_pods_namespace option. This is needed because if the option is specified, then only that namespace will be scraped, meaning only a Role is needed, not a ClusterRole. Until now a ClusterRole was always needed, because the Informer by default always used resources across all namespaces. This is an issue if you only have access to create a Role, but not a ClusterRole.

@telegraf-tiger telegraf-tiger bot added area/prometheus fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Apr 10, 2023
@Ivaylogi98 Ivaylogi98 marked this pull request as ready for review April 10, 2023 12:29
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@powersj powersj mentioned this pull request Apr 10, 2023
Closed
@powersj powersj self-assigned this Apr 10, 2023
powersj
powersj reviewed Apr 10, 2023
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I'd like confirmation from the original bug reporters that this resolves the issue and then we can look at merging.

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Apr 12, 2023
@powersj powersj assigned srebhan and unassigned powersj Apr 12, 2023
srebhan
srebhan approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix @Ivaylogi98! Thanks!

@srebhan srebhan merged commit 14c84a0 into influxdata:master Apr 12, 2023
powersj pushed a commit that referenced this pull request Apr 24, 2023
@Ivaylogi98 @powersj
fix(inputs.prometheus): Add namespace option in k8s informer factory (#…
0360580 
…13063)

Co-authored-by: ivayloi2 <ivayloi2@vmware.com>
(cherry picked from commit 14c84a0)
@Porkepix Porkepix mentioned this pull request Apr 24, 2023
Merged
@redbaron redbaron mentioned this pull request Jun 9, 2023
Closed
@srebhan srebhan added this to the v1.26.2 milestone Jun 21, 2023
@n0coast n0coast mentioned this pull request Sep 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
area/prometheus fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.26.2
Development

Successfully merging this pull request may close these issues.

inputs.prometheus require cluster level permissions even when scoped to a namespace
3 participants
@Ivaylogi98 @powersj @srebhan