-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs.prometheus): avoid race when creating informer factory #13231
Conversation
@powersj , test failure seems unrelated |
…n init Avoids very tiny and unlikely race between Gather and registerPod funcs
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
@samskan can you give the artifacts in this PR a try, or as suggested on the bug, build this PR with Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the quick PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the fix @redbaron!
Informer factory creation had a race when multiple instances of the plugin are present. It might resolve #13219 , but I am still not sure what have caused it.
fixes: #13219