Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(outputs): Add plugin for nebius cloud monitoring #13379

Merged
merged 21 commits into from
Jun 9, 2023
Merged

feat(outputs): Add plugin for nebius cloud monitoring #13379

merged 21 commits into from
Jun 9, 2023

Conversation

abrekhov
Copy link
Contributor

@abrekhov abrekhov commented Jun 1, 2023

Required for all PRs

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jun 1, 2023
@srebhan srebhan changed the title feat!: add new plugin for nebius cloud monitoring feat(outputs): Add plugin for nebius cloud monitoring Jun 2, 2023
srebhan
srebhan reviewed Jun 2, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @abrekhov! The code looks quite good already, I have some comments though... One thing I do not get is the authentication handling, it would be nice if you enlighten me. :-)

plugins/outputs/nebius_cloud_monitoring/README.md Outdated Show resolved Hide resolved
plugins/outputs/nebius_cloud_monitoring/sample.conf Outdated Show resolved Hide resolved
plugins/outputs/nebius_cloud_monitoring/nebius_cloud_monitoring.go Outdated Show resolved Hide resolved
plugins/outputs/nebius_cloud_monitoring/nebius_cloud_monitoring.go Outdated Show resolved Hide resolved
plugins/outputs/nebius_cloud_monitoring/nebius_cloud_monitoring.go Outdated Show resolved Hide resolved
plugins/outputs/nebius_cloud_monitoring/nebius_cloud_monitoring.go Outdated Show resolved Hide resolved
plugins/outputs/nebius_cloud_monitoring/nebius_cloud_monitoring.go Outdated Show resolved Hide resolved
plugins/outputs/nebius_cloud_monitoring/nebius_cloud_monitoring_test.go Outdated Show resolved Hide resolved
plugins/outputs/nebius_cloud_monitoring/nebius_cloud_monitoring_test.go Outdated Show resolved Hide resolved
plugins/outputs/nebius_cloud_monitoring/nebius_cloud_monitoring_test.go Outdated Show resolved Hide resolved
@srebhan srebhan self-assigned this Jun 2, 2023
@srebhan srebhan added new plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Jun 2, 2023
@abrekhov
Copy link
Contributor Author

abrekhov commented Jun 6, 2023

@srebhan Could you please check latest version? I wish to correct everything until 1.27 be released. Thanks!

srebhan
srebhan reviewed Jun 7, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abrekhov thanks for the nice update. I think we are close... Two comments and the ones still open from last time...

plugins/outputs/nebius_cloud_monitoring/nebius_cloud_monitoring.go Outdated Show resolved Hide resolved
plugins/outputs/nebius_cloud_monitoring/nebius_cloud_monitoring.go Outdated Show resolved Hide resolved
powersj
powersj reviewed Jun 7, 2023
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! Looks nice, few questions inline.

We would love to land this this week, which is why I am not waiting for Sven to mark this as ready for final review to do a review ;)

plugins/outputs/nebius_cloud_monitoring/sample.conf Outdated Show resolved Hide resolved
plugins/outputs/nebius_cloud_monitoring/nebius_cloud_monitoring.go Outdated Show resolved Hide resolved
plugins/outputs/nebius_cloud_monitoring/README.md Outdated Show resolved Hide resolved
plugins/outputs/nebius_cloud_monitoring/README.md Outdated Show resolved Hide resolved
plugins/outputs/nebius_cloud_monitoring/nebius_cloud_monitoring.go Show resolved Hide resolved
@powersj
Copy link
Contributor

powersj commented Jun 8, 2023

I think removing service config option is all that is left and I can give it the +1

powersj
powersj approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jun 8, 2023
srebhan
srebhan approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I have two more comments on logging output but nothing that should hold-up this PR... Please let me know if you can fix those otherwise I will just commit them right before the merge...

plugins/outputs/nebius_cloud_monitoring/nebius_cloud_monitoring.go Outdated Show resolved Hide resolved
plugins/outputs/nebius_cloud_monitoring/nebius_cloud_monitoring.go Outdated Show resolved Hide resolved
abrekhov and others added 2 commits June 9, 2023 14:52
@abrekhov @srebhan
Update plugins/outputs/nebius_cloud_monitoring/nebius_cloud_monitorin…
ef4a605 
…g.go

Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@abrekhov @srebhan
Update plugins/outputs/nebius_cloud_monitoring/nebius_cloud_monitorin…
2dfe279 
…g.go

Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Jun 9, 2023

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@powersj powersj merged commit dada11e into influxdata:master Jun 9, 2023
@powersj
Copy link
Contributor

powersj commented Jun 9, 2023

Thank you all!

@abrekhov
Copy link
Contributor Author

abrekhov commented Jun 9, 2023

Thank you for review guys!

@srebhan @powersj

@chenrui333 chenrui333 mentioned this pull request Jun 13, 2023
Merged
@srebhan srebhan added this to the v1.27.0 milestone Jun 21, 2023
@abrekhov abrekhov mentioned this pull request Feb 2, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@powersj powersj powersj approved these changes

Assignees

@srebhan srebhan

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin new plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.27.0
Development

Successfully merging this pull request may close these issues.
3 participants
@abrekhov @powersj @srebhan