Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(inputs.docker): Add disk usage #13894

Merged
merged 11 commits into from
Sep 27, 2023
Merged

feat(inputs.docker): Add disk usage #13894

merged 11 commits into from
Sep 27, 2023

Conversation

R290
Copy link
Contributor

@R290 R290 commented Sep 8, 2023 •
edited
Loading

Required for all PRs

resolves #13858

Added disk usage for container, image and volume objects to the docker input plugin.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Sep 8, 2023
@powersj
Copy link
Contributor

powersj commented Sep 15, 2023 •
edited
Loading

@R290 - you have this as a draft still; is that intentional? I ask because I don't want you to think we are ignoring this ;)

@R290
Copy link
Contributor Author

R290 commented Sep 15, 2023 •
edited
Loading

@powersj - thanks for reaching out! The draft state is completely intentional, I wanted to add some tests before marking the pull request as ready for review.

@R290 R290 marked this pull request as ready for review September 15, 2023 18:59
srebhan
srebhan reviewed Sep 18, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @R290! I do have some comments, mostly about not adding todo but implement those right away.

plugins/inputs/docker/docker_testdata.go Outdated Show resolved Hide resolved
plugins/inputs/docker/docker_test.go Outdated Show resolved Hide resolved
plugins/inputs/docker/docker_test.go Outdated Show resolved Hide resolved
plugins/inputs/docker/client.go Outdated Show resolved Hide resolved
plugins/inputs/docker/docker.go Outdated Show resolved Hide resolved
plugins/inputs/docker/docker.go Outdated Show resolved Hide resolved
plugins/inputs/docker/docker.go Outdated Show resolved Hide resolved
plugins/inputs/docker/docker.go Outdated Show resolved Hide resolved
plugins/inputs/docker/docker.go Outdated Show resolved Hide resolved
@srebhan srebhan self-assigned this Sep 18, 2023
@srebhan srebhan changed the title feat: add docker disk usage feat(inputs.docker): Add disk usage Sep 18, 2023
@srebhan srebhan added area/docker plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Sep 18, 2023
R290 and others added 4 commits September 19, 2023 19:46
srebhan
srebhan approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice PR @R290!

@srebhan
Copy link
Member

srebhan commented Sep 26, 2023

@R290 can you please run make tidy on the current state to make CI happy!?

@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 27, 2023
@srebhan srebhan assigned powersj and unassigned srebhan Sep 27, 2023
@powersj powersj merged commit 705176b into influxdata:master Sep 27, 2023
@github-actions github-actions bot added this to the v1.29.0 milestone Sep 27, 2023
@R290 R290 mentioned this pull request Nov 20, 2023
Closed
@Porkepix Porkepix mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@powersj powersj powersj approved these changes

Assignees

@powersj powersj

Labels
area/docker feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.29.0
Development

Successfully merging this pull request may close these issues.

Add disk usage to docker input plugin
3 participants
@R290 @powersj @srebhan