-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.opcua_listener): Add monitoring params #13923
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Thank you very much for the PR! I have a few comments and questions below for you to review.
Thanks!
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 🥳 This pull request decreases the Telegraf binary size by -2.36 % for linux amd64 (new size: 197.3 MB, nightly size 202.1 MB) 📦 Click here to get additional PR build artifactsArtifact URLs |
5eaf36e
to
ea65973
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution @reindlt. Only two minor comments from my side...
@srebhan thanks for taking over the corrections. It seems that the failed checks are not related to changes within this PR. |
Hi, Config: Error: |
@JeroenVanHoye please do not comment on old PR but open a new issue with your (redacted) config and the corresponding log... |
Required for all PRs
resolves #13891
new structs have been added to input client representing monitoring and data change filter parameters
new function has been added to subscribe client in order to override default values for parameters that have been specified in the config
monitoring parameters have been added to existing tests for subscribe client