fix(parsers.avro): Only attempt to read CA Cert file if filename is not empty string #13939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
fix
athornton
force-pushed
the
fix/avro-capath
branch
from
4812e18 to
de9422a
Compare
powersj
approved these changes
Sep 18, 2023
|
Wow! That was really fast! |
athornton
force-pushed
the
fix/avro-capath
branch
from
de9422a to
81a77b6
Compare
powersj
added
the
ready for final review
3 tasks
srebhan
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Also sorry from my side... How could I miss this? :-( Thanks for the fix @athornton!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs
resolves #13938
Moved the attempted opening of the CA cert file inside the check that that filename is not the empty string.