Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.rabbitmq): Add secretstore support for username and password #13991

Merged
merged 4 commits into from
Sep 27, 2023

Conversation

yonathanamir
Copy link
Contributor

resolves #13956

Adds secretstore support to the username and password options of the rabbitmq input.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Sep 26, 2023
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting the PR @yonathanamir! One small suggestion...

plugins/inputs/rabbitmq/rabbitmq.go Outdated Show resolved Hide resolved
@srebhan srebhan changed the title feat(inputs.inputs.rabbitmq): Add secretstore support for username, password feat(inputs.rabbitmq): Add secretstore support for username and password Sep 26, 2023
@srebhan srebhan self-assigned this Sep 26, 2023
@srebhan srebhan added area/rabbitmq plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Sep 26, 2023
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

⚠️ This pull request increases the Telegraf binary size by 2.20 % for linux amd64 (new size: 202.0 MB, nightly size 197.7 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for converting the plugin @yonathanamir! Much appreciated!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 27, 2023
@srebhan srebhan assigned powersj and unassigned srebhan Sep 27, 2023
@powersj powersj merged commit 1f029cb into influxdata:master Sep 27, 2023
4 checks passed
@github-actions github-actions bot added this to the v1.29.0 milestone Sep 27, 2023
@yonathanamir yonathanamir deleted the yonathanamirrabbitmq-secret branch September 28, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rabbitmq feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RabbitMQ Input secretstore support
3 participants