Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(outputs.azure_data_explorer): Set user agent string #14047

Conversation

ag-ramachandran
Copy link
Contributor

@ag-ramachandran ag-ramachandran commented Oct 3, 2023

Required for all PRs

  • Updated associated README.md. - No changes applicable, hence not updated
  • Wrote appropriate unit tests. - No test changes are applicable (this is server side telemetry)
  • Pull request title or commits are in conventional commit format

resolves #14046

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Oct 3, 2023

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Oct 3, 2023
@ag-ramachandran
Copy link
Contributor Author

!signed-cla

@ag-ramachandran ag-ramachandran changed the title feat(outputs.azure_data_explorer): Add telemetry headers/options to connection for troubleshooting feat(outputs.azure_data_explorer): add telemetry headers and options to connection string for troubleshooting Oct 3, 2023
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

In general, I do not see an issue with setting user-agent like settings and sharing them with the endpoint. I would even ask you set the version correctly using ProductToken instead of the hard-coded 1.0.0.

I understand the value in knowing these details when supporting users. However, I am less inclined to allow you to start sharing user's config details for the purpose of telemetry, without their permissions. Sharing those details should be opt-in.

@ag-ramachandran ag-ramachandran force-pushed the feature/14046-AddTelegrafUserAgentInConnector branch from 84dedb5 to a741590 Compare October 3, 2023 15:58
@ag-ramachandran
Copy link
Contributor Author

feat(outputs.azure_data_explorer): add telemetry headers and options to connection string for troubleshooting

Thanks for the PR.

In general, I do not see an issue with setting user-agent like settings and sharing them with the endpoint. I would even ask you set the version correctly using ProductToken instead of the hard-coded 1.0.0.

I understand the value in knowing these details when supporting users. However, I am less inclined to allow you to start sharing user's config details for the purpose of telemetry, without their permissions. Sharing those details should be opt-in.

Sure @powersj, I have removed config specific options. Right now only version of telegraf is passed in so there is no user config that is passed.

Does this look good

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 3, 2023
@powersj powersj changed the title feat(outputs.azure_data_explorer): add telemetry headers and options to connection string for troubleshooting feat(outputs.azure_data_explorer): Set user agent string Oct 3, 2023
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Oct 3, 2023

@srebhan srebhan added the area/azure Azure plugins including eventhub_consumer, azure_storage_queue, azure_monitor label Oct 4, 2023
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @ag-ramachandran!

@srebhan srebhan merged commit 4759214 into influxdata:master Oct 4, 2023
5 checks passed
@github-actions github-actions bot added this to the v1.29.0 milestone Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/azure Azure plugins including eventhub_consumer, azure_storage_queue, azure_monitor feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add user agent headers to Azure Data Explorer
3 participants