-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(outputs.azure_data_explorer): Set user agent string #14047
feat(outputs.azure_data_explorer): Set user agent string #14047
Conversation
Thanks so much for the pull request! |
!signed-cla |
…to connection string for troubleshooting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
In general, I do not see an issue with setting user-agent like settings and sharing them with the endpoint. I would even ask you set the version correctly using ProductToken instead of the hard-coded 1.0.0.
I understand the value in knowing these details when supporting users. However, I am less inclined to allow you to start sharing user's config details for the purpose of telemetry, without their permissions. Sharing those details should be opt-in.
84dedb5
to
a741590
Compare
…ve additional options
Sure @powersj, I have removed config specific options. Right now only version of telegraf is passed in so there is no user config that is passed. Does this look good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution @ag-ramachandran!
Required for all PRs
resolves #14046