Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.netflow): Fix sFlow metric timestamp #14195

Merged

Conversation

Hipska
Copy link
Contributor

@Hipska Hipska commented Oct 26, 2023

Required for all PRs

Currently, the sysUptime field was used, but that isn't a unix timestamp:

The time (in hundredths of a second) since the network management portion of the system was last re-initialized.

This PR rectifies this and uses the same as for the netflow decoders.

-netflow,source=127.0.0.1,version=sFlowV5 sys_uptime=12414u,agent_ip="192.168.119.184",agent_subid=100000u,seq_number=2u,in_snmp=3u,port_name="eno1",ip_version="IPv4" 12414000000
+netflow,source=127.0.0.1,version=sFlowV5 sys_uptime=12414u,agent_ip="192.168.119.184",agent_subid=100000u,seq_number=2u,in_snmp=3u,port_name="eno1",ip_version="IPv4" 16983296530

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Oct 26, 2023
@telegraf-tiger
Copy link
Contributor

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting and fixing this @Hipska!

@srebhan srebhan added area/network New plugins or feature relating to Network Monitoring ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Oct 30, 2023
@powersj powersj merged commit 12d8c3d into influxdata:master Oct 30, 2023
5 checks passed
@github-actions github-actions bot added this to the v1.28.4 milestone Oct 30, 2023
@Hipska Hipska deleted the fix/inputs/netflow/sflow_timestamp branch October 31, 2023 13:15
powersj pushed a commit that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/network New plugins or feature relating to Network Monitoring fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants