Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.openweathermap): Add per-city query scheme for current weather #14214

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Oct 30, 2023

resolves #6043

This PR allows to use the well-documented and more-frequently updated weather endpoint which does not handle city-batch-queries. Therefore an individual query-scheme is implemented with a backward compatible setting in the new query_style option.

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Oct 30, 2023
@telegraf-tiger
Copy link
Contributor

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 30, 2023
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good. My primary review was around ensuring backwards compatibility.

@powersj powersj merged commit 3b2d8c5 into influxdata:master Oct 31, 2023
4 checks passed
@github-actions github-actions bot added this to the v1.29.0 milestone Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

openweathermap update interval
2 participants