Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inputs.intel_rdt): Do not fail on missing PIDs #14274

Merged
merged 3 commits into from
Nov 15, 2023
Merged

fix(inputs.intel_rdt): Do not fail on missing PIDs #14274

merged 3 commits into from
Nov 15, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Nov 10, 2023

Instead, continue the loop as some PIDs can be so short-lived that they do not exist by the time we look for them.

fixes: #14272

@powersj
fix(inputs.intel_rdt): Do not fail on missing PIDs
ae5b153 
Instead, continue the loop as some PIDs can be so short-lived that they
do not exist by the time we look for them.

fixes: influxdata#14272
@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Nov 10, 2023
@powersj powersj mentioned this pull request Nov 10, 2023
Closed
@powersj powersj self-assigned this Nov 10, 2023
@powersj powersj marked this pull request as ready for review November 14, 2023 14:07
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 14, 2023
@powersj powersj assigned srebhan and unassigned powersj Nov 14, 2023
srebhan
srebhan approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @powersj!

@srebhan srebhan merged commit 05bb277 into influxdata:master Nov 15, 2023
4 checks passed
@github-actions github-actions bot added this to the v1.29.0 milestone Nov 15, 2023
@srebhan srebhan modified the milestones: v1.29.0, v1.28.5 Nov 15, 2023
powersj added a commit that referenced this pull request Nov 15, 2023
@powersj
fix(inputs.intel_rdt): Do not fail on missing PIDs (#14274)
48e72be 
(cherry picked from commit 05bb277)
@Porkepix Porkepix mentioned this pull request Nov 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LarssonOliver LarssonOliver LarssonOliver left review comments

@p-zak p-zak p-zak approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.28.5
Development

Successfully merging this pull request may close these issues.

[inputs.intel_rdt] Short running subprocess crashes plugin.
4 participants
@powersj @LarssonOliver @srebhan @p-zak