-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs.s7comm): Truncate string to actual length #14283
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phagemann
changed the title
fix(inputs.s7comm) truncate string to actual length
fix(inputs.s7comm): truncate string to actual length
Nov 13, 2023
phagemann
force-pushed
the
s7comm-strings
branch
from
November 13, 2023 10:40
49c2ce1
to
23bd12c
Compare
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
srebhan
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this bug @phagemann!
srebhan
changed the title
fix(inputs.s7comm): truncate string to actual length
fix(inputs.s7comm): Truncate string to actual length
Nov 13, 2023
srebhan
added
area/iot
New plugins or features relating to IoT monitoring
area/agent
ready for final review
This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
plugin/input
1. Request for new input plugins 2. Issues/PRs that are related to input plugins
labels
Nov 13, 2023
powersj
approved these changes
Nov 13, 2023
powersj
pushed a commit
that referenced
this pull request
Nov 15, 2023
(cherry picked from commit fd65ce8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/iot
New plugins or features relating to IoT monitoring
fix
pr to fix corresponding bug
plugin/input
1. Request for new input plugins 2. Issues/PRs that are related to input plugins
ready for final review
This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #
Change string parsing to truncate string at actual length instead of the max string length.
Byte 0 reflects the max string length,
Byte 1 reflects the actual length
Behavior before this PR:
got [30 17 76 95 50 52 48 95 84 75 49 52 95 51 48 46 112 114 100 112 114 100 97 111 46 112 114 100 76 79 0 0] for field "ProgrammName" @ 24 --> L_240_TK14_30.prdprdao.prdLO (string)
now:
got [30 17 76 95 50 52 48 95 84 75 49 52 95 51 48 46 112 114 100 112 114 100 97 111 46 112 114 100 76 79 0 0] for field "ProgrammName" @ 24 --> L_240_TK14_30.prd (string)