Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(inputs.kafka_consumer): Use metric name from message header #14320

Merged
merged 2 commits into from
Nov 27, 2023
Merged

feat(inputs.kafka_consumer): Use metric name from message header #14320

merged 2 commits into from
Nov 27, 2023

Conversation

BelousovAntonV
Copy link
Contributor

Required for all PRs

resolves #13980
Adds a mechanism to Kafka_consumer input for overriding metric name with a value from the kafka message header.

@BelousovAntonV BelousovAntonV changed the title feature(inputs.kafka_consumer). Override metric name from the kafka message header feat(inputs.kafka_consumer): override metric name from the kafka message header Nov 20, 2023
@srebhan srebhan changed the title feat(inputs.kafka_consumer): override metric name from the kafka message header feat(inputs.kafka_consumer): Use metric name from message header Nov 20, 2023
srebhan
srebhan approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BelousovAntonV!

@srebhan srebhan added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin area/kafka ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Nov 20, 2023
powersj
powersj approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!

@powersj powersj merged commit cd83c70 into influxdata:master Nov 27, 2023
5 of 6 checks passed
@github-actions github-actions bot added this to the v1.29.0 milestone Nov 27, 2023
@Porkepix Porkepix mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@powersj powersj powersj approved these changes

Assignees

@powersj powersj

Labels
area/kafka feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.29.0
Development

Successfully merging this pull request may close these issues.

feature(inputs.kafka_consumer). Override metric name from the kafka message header
3 participants
@BelousovAntonV @powersj @srebhan