Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.s7comm): Reconnect if query fails #14394

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Dec 6, 2023

Summary

Currently, the plugin goes defunct if the connection is lost after Start, e.g. in case the remote machine is rebooted or the network has issues.
This PR tries to reconnect if reading the defined area(s) fails in Gather and skips the gather cycle. The skipping is necessary as otherwise we try to reconnect on each and every batch scheduled for gathering.

Checklist

  • No AI generated code was used in this PR
  • Unit test

Related issues

resolves #14392

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Dec 6, 2023
@srebhan srebhan force-pushed the s7comm_issue_14392 branch from 19ee4cf to 4da5dc7 Compare December 6, 2023 20:01
@srebhan srebhan added area/iot New plugins or features relating to IoT monitoring ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Dec 7, 2023
@srebhan srebhan merged commit 41b7a3d into influxdata:master Dec 7, 2023
23 checks passed
@srebhan srebhan deleted the s7comm_issue_14392 branch December 7, 2023 11:28
@github-actions github-actions bot added this to the v1.29.0 milestone Dec 7, 2023
@GitTurboy
Copy link

This bug occurred in new version again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/iot New plugins or features relating to IoT monitoring fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can I config the s7comm plugin to reconnect to ther PLC after it Reseted
3 participants