fix(service): Allow notify access from all #14517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srebhan
added
the
ready for final review
powersj
added a commit
that referenced
this pull request
Jan 8, 2024
(cherry picked from commit 6761200)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
NotifyAccess=alloption to the systemd service file we use. Without this,NotifyAccessis set tomain, due toType=notify. This means only the main pid can communicate. Users using exec/execd like plugins need to be able to communicate with other PIDs.See: https://www.freedesktop.org/software/systemd/man/latest/systemd.service.html#NotifyAccess=
Checklist
Related issues
resolves #14500