Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inputs.temp): Recover pre-v1.22.4 temperature sensor readings #14575

Merged
merged 5 commits into from
Jan 18, 2024
Merged

fix(inputs.temp): Recover pre-v1.22.4 temperature sensor readings #14575

merged 5 commits into from
Jan 18, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Jan 15, 2024 •
edited
Loading

Summary

This PR fixes a regression introduced by gopsutils and brings back additional temperature sensor-readings present before v1.22.4.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #11294

@srebhan srebhan changed the title Temp issue 11294 fix(inputs.temp): Recover pre-v1.22.4 temperature sensor readings Jan 15, 2024
@srebhan srebhan added regression something that used to work, but is now broken fix pr to fix corresponding bug area/system plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jan 15, 2024
@srebhan srebhan mentioned this pull request Jan 15, 2024
Closed
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jan 16, 2024
powersj
powersj reviewed Jan 17, 2024
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, need you to rename a file or justify it ;) and then this is good to go.

plugins/inputs/temp/temp_nolinux.go Outdated Show resolved Hide resolved
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@powersj powersj merged commit 9aee268 into influxdata:master Jan 18, 2024
26 checks passed
@github-actions github-actions bot added this to the v1.29.3 milestone Jan 18, 2024
powersj pushed a commit that referenced this pull request Jan 29, 2024
@srebhan @powersj
fix(inputs.temp): Recover pre-v1.22.4 temperature sensor readings (#1…
4019182 
…4575)

(cherry picked from commit 9aee268)
@Porkepix Porkepix mentioned this pull request Jan 30, 2024
Merged
This was referenced Jan 30, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj left review comments

Assignees

@powersj powersj

Labels
area/system fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. regression something that used to work, but is now broken
Projects
None yet
Milestone
v1.29.3
Development

Successfully merging this pull request may close these issues.

Undocumented regression in temp plugin
2 participants
@srebhan @powersj