-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.smart): Add a "device_type" tag to differentiate disks behind a RAID controller #14613
feat(inputs.smart): Add a "device_type" tag to differentiate disks behind a RAID controller #14613
Conversation
Thanks so much for the pull request! |
when they're standing behind the same controller
e0f3dd4
to
1540b53
Compare
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to put this together!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the nice improvement @Maxi-Mega!
…hind a RAID controller (influxdata#14613) Co-authored-by: Thomas Delbende <thomas.delbende@bleemeo.com>
Summary
When multiple disks are standing behind the same controller, we currently cannot tell them apart.
With these changes, an extra tag
device_type
can be added to help differentiate them.This tag can be enabled from the config with the
tag_with_device_type
property, and is disabled by default to preserve backward compatibility.Sample output of a Dell server with 8 physical disks:
Checklist
Related issues
resolves #4881, #13090