-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(common.encoding): Remove locally-defined errors and use upstream ones #14627
Conversation
Thanks so much for the pull request! |
!signed-cla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @Snelius30!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
Summary
We have a local defined error (ie ErrShortDst, ErrShortSrc) objects in decoder_reader.go which has transferred from an original transformer package. Those uses inside the Read() function to properly manage a slice allocations. It does not work
cause errors.Is never set to true cause local errors object it's not the same transformer defined errors objects.
I got this error on my production when character_encoding = "utf8" option was used for inputs.file and dst buffer size is not enough to decode obviously.
Well, we need just to use a proper error objects. This PR to solve the problem. Thx.