Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.kafka_consumer): Correctly setting name to msg_headers_as_tags #14679

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

nobel6018
Copy link
Contributor

@nobel6018 nobel6018 commented Feb 4, 2024

Summary

Correctly change Kafka telegraf's configuration variable name to msg_headers_as_tags from msg_headers_to_tags

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #14678

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Feb 4, 2024

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Feb 4, 2024
@nobel6018
Copy link
Contributor Author

!signed-cla

@nobel6018
Copy link
Contributor Author

!signed-cla

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Feb 5, 2024
@srebhan srebhan changed the title fix: correctly change variable name to msg_headers_as_tags from msg_headers_to_tags fix(inputs.kafka): Correctly setting name to msg_headers_as_tags Feb 5, 2024
@srebhan srebhan changed the title fix(inputs.kafka): Correctly setting name to msg_headers_as_tags fix(inputs.kafka_consumer): Correctly setting name to msg_headers_as_tags Feb 5, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @nobel6018 but I think you also need to update sample.conf and run make docs!

@srebhan srebhan added area/kafka plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Feb 5, 2024
@nobel6018
Copy link
Contributor Author

nobel6018 commented Feb 6, 2024

Thanks for the fix @nobel6018 but I think you also need to update sample.conf and run make docs!

Thank you for your comment. @srebhan

  • ✅ I updated sample.conf and pushed it
  • ✅ I ran make docs

@nobel6018 nobel6018 requested a review from srebhan February 6, 2024 02:38
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @nobel6018!

@srebhan srebhan merged commit 4c2ba74 into influxdata:master Feb 6, 2024
26 checks passed
@github-actions github-actions bot added this to the v1.29.5 milestone Feb 6, 2024
powersj pushed a commit that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kafka fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong Kafka plugin configuration variable msg_headers_to_tags
3 participants