Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.win_services): Make service selection case-insensitive #14684

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Feb 5, 2024

Summary

This PR allows to specify the services to include or exclude in a case-insensitive way.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #8796

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Feb 5, 2024
@srebhan srebhan added the area/windows Related to windows plugins (win_eventlog, win_perf_counters, win_services) label Feb 5, 2024
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Feb 5, 2024
@powersj powersj merged commit 3591546 into influxdata:master Feb 6, 2024
26 checks passed
@github-actions github-actions bot added this to the v1.30.0 milestone Feb 6, 2024
@1tft
Copy link

1tft commented Mar 28, 2024

@srebhan I wonder if you forgot to change comment in

## Names of the services to monitor. Leave empty to monitor all the available services on the host. Globs accepted. Case sensitive.
regarding case insensitive?

@powersj
Copy link
Contributor

powersj commented Mar 28, 2024

Yep, I've put up #15077

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/windows Related to windows plugins (win_eventlog, win_perf_counters, win_services) feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Win_services: case sensitive in service names
3 participants