Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.postgresql_extensible): Add support for bool tags #14707

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

phemmer
Copy link
Contributor

@phemmer phemmer commented Feb 8, 2024

Summary

Fixes postgresql_extensible to support bool tags.

Previous behavior was to silently ignore the provided configuration and convert the tag into a field, which is pretty bad behavior IMHO. While I would argue that if the configuration can't be followed, an error should be emitted and the metric dropped, that's out of scope. This PR only fixes the specific bool issue.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Feb 8, 2024
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Feb 8, 2024

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Feb 8, 2024
@srebhan srebhan changed the title fix(inputs.postgresql_extensible): support bool tags fix(inputs.postgresql_extensible): Add support for bool tags Feb 9, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @phemmer!

@srebhan srebhan merged commit ad9b771 into influxdata:master Feb 9, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.29.5 milestone Feb 9, 2024
powersj pushed a commit that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/postgresql fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants